>>>>> "Vivek" == Vivek Goyal <vgoyal@xxxxxxxxxx> writes: >> + blk_add_request_payload(rq, bio_page(bio), sdp->sector_size); Vivek> I was just curious about what above function is doing. This is Vivek> strange is that we already have the bio->io_vec initialized and Vivek> we are reusing that to overwrite same bio with same information Vivek> and trying to update rq again with same information. Yeah, you're right. I don't think this is needed now that we distinguish between bio_has_data() and bio_is_rw() when mapping the request. Mike, would you mind stubbing out the blk_add_request_payload call in sd_set_write_same_cmnd() and rerun your iSCSI thinp test? It works for me with SAS/FC... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
