>>>>> "Vivek" == Vivek Goyal <vgoyal@xxxxxxxxxx> writes: Vivek> So in this patch bio_is_rw() == bio_is_data(). Do they diverge in Vivek> later patches? Yep. Vivek> Some of the flags in REQ_NOMERGE_FLAGS are rq only and should not Vivek> be used on bio. For example REQ_NOMERGE and REQ_STARTED. Right, but even if the caller passed down invalid flags they'd be masked off when we create the request. Vivek> Will it be better to define BIO_NOMERGE_FLAGS separately? I'd rather not have things defined two places. That leads us down the path to the mess we have now. However, I don't have a problem with doing: #define BIO_NOMERGE_FLAGS (REQ_NOMERGE_FLAGS & REQ_COMMON_MASK) -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
