On 03/05/2012 09:42 PM, Yi Zou wrote:
> When performing a cable pull test w/ active stress I/O using fio over
> a dual port Intel 82599 FCoE CNA, w/ 256LUNs on one port and about 32LUNs
> on the other, it is observed that the system becomes not usable due to
> scsi-ml being busy printing the error messages for all the failing commands.
> I don't believe this problem is specific to FCoE and these commands are
> anyway failing due to link being down (DID_NO_CONNECT), just rate-limit
> the messages here to solve this issue.
>
> Signed-off-by: Yi Zou <yi.zou@xxxxxxxxx>
> Cc: www.Open-FCoE.org <devel@xxxxxxxxxxxxx>
Hi Zou,
you shouldn't use printk_ratelimit .
checkpatch says: WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
Tomas
> ---
>
> drivers/scsi/scsi_lib.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index b2c95db..e2128d9 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -934,7 +934,8 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
> case ACTION_FAIL:
> /* Give up and fail the remainder of the request */
> scsi_release_buffers(cmd);
> - if (!(req->cmd_flags & REQ_QUIET)) {
> + if (!(req->cmd_flags & REQ_QUIET) &&
> + printk_ratelimit()) {
> if (description)
> scmd_printk(KERN_INFO, cmd, "%s\n",
> description);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
