-----Original Message----- From: Mike Christie <michaelc@xxxxxxxxxxx> Date: Mon, 5 Mar 2012 18:49:37 -0800 To: Vikas Chaudhary <vikas.chaudhary@xxxxxxxxxx> Cc: "jbottomley@xxxxxxxxxxxxx" <jbottomley@xxxxxxxxxxxxx>, scsi <linux-scsi@xxxxxxxxxxxxxxx>, Ravi Anand <ravi.anand@xxxxxxxxxx>, Lalit Chandivade <lalit.chandivade@xxxxxxxxxx> Subject: Re: [PATCH 10/11] qla4xxx: Added ping support >On 02/13/2012 07:00 AM, vikas.chaudhary@xxxxxxxxxx wrote: >> + >> + if (mbox_sts_entry->out_mbox[0] == MBOX_STS_COMMAND_COMPLETE) >> + status = QLA_SUCCESS; >> + else >> + status = QLA_ERROR; >> + >> + data_size = sizeof(mbox_sts_entry->out_mbox); >> + >> + qla4xxx_post_ping_evt_work(ha, status, mrb->pid, data_size, >> + (uint8_t *) mbox_sts_entry->out_mbox); >> + break; >> + > >Not sure what I was thinking. This is not going to work. > >We are not going to pass back vendor specific values, and then have >multiple decoders in userspace. > >What are you trying to pass back up to userspace? Can you add a enum or >defines for some common error values? We can also pass back vendor >specific info, but we have to also have some common error cls info or it >is completely useless to other apps. > >And, can we get more info that if it failed or not? I modified code to return detail error code that other vendors can also use. I am sending patch for same in next email. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
