t->task_state_lock can be changed to simple spin lock instead of 'irq spin lock' Initially I thought to do so. But could not get the intention of the developer why he used an irq lock there. Hence left it unchanged. Just changed from 'irqsave spin lock' to 'irq spin lock' regard santosh On Thu, Mar 1, 2012 at 8:07 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Thu, Mar 01, 2012 at 07:54:57PM +0530, santosh prasad nayak wrote: >> The warnings are there since from the beginning. >> Even before my fix. >> >> There are two locks: >> 1. pm8001_ha->lock >> 2. t->task_state_lock >> > > Yes. But IRQs are either enabled or disabled for the CPU. You > can't enable them twice. > > In this case we enable them in the first call to unlock and the > second call doesn't do anything. So possibly the current behavior > is correct and we should change the second unlock or possibly the > current behavior is wrong and we should change the first unlock. > > But actually the email was more of just a form letter. Perhaps Jack > knows what to do here... > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
