On Thu, 2012-02-23 at 12:14 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
>
> We don't need to change the sign of our prm->residual field; the target
> core sets a flag to distinguish overflow and underflow, but
> se_cmd->residual_count is always positive. The existing code seems to
> be a carryover from the port from scst, which uses the sign of the
> residual field to distinguish overflow and underflow.
>
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 9282014..b12fb84 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -1808,7 +1808,6 @@ static int qla_tgt_pre_xmit_response(struct qla_tgt_cmd *cmd, struct qla_tgt_prm
> se_cmd->t_task_cdb ? se_cmd->t_task_cdb[0] : 0,
> cmd->bufflen, prm->rq_result);
> prm->rq_result |= SS_RESIDUAL_OVER;
> - prm->residual = -prm->residual;
> }
>
> if (xmit_type & QLA_TGT_XMIT_STATUS) {
Applied. Thanks Roland!
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
