Hi, On 02/15/12 20:29, Bart Van Assche wrote: > On Wed, Feb 15, 2012 at 3:26 AM, Jun'ichi Nomura <j-nomura@xxxxxxxxxxxxx> wrote: >> I think this patch is good, too. >> Since QUEUE_FLAG_DEAD is also racy, it is not much different >> from queuedata check, IMO. > > Are you sure ? As far as I know the block layer takes care of > synchronizing queue flag modifications against request_fn invocations. QUEUE_FLAG_DEAD is set outside of queue_lock. So it's racy. However, it's single directional change and the race is benign if the driver, who sets QUEUE_FLAG_DEAD, is ready to reject requests. q->queuedata is same with that regard. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
