>>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: >> + BUG_ON(length != bdev_logical_block_size(bdev)); Mike> Why require @length to be passed in if we can easily determine the Mike> only correct length, via bdev_logical_block_size, locally? Just sanity checking since the caller is passing in a buffer pointer. See my comment in the patch series introduction about a page vs a buffer. I don't really care whether we pick one or the other. Whatever makes the most sense to dm, md and the filesystems... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html