> -----Original Message----- > From: usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx > [mailto:usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Greg KH > Sent: Tuesday, January 24, 2012 12:01 PM > To: Alan Stern; James Bottomley > Cc: Matthew Dharm; Perry Wagle; USB Storage list; SCSI > development list > Subject: [usb-storage] Re: [PATCH 0/3] SCSI & usb-storage: > new flags for VPD pages and REPORT LUNS > > On Tue, Jan 10, 2012 at 01:42:40PM -0500, Alan Stern wrote: > > James and Greg: > > > > Perry Wagle reports that his new USB-ESATA drives don't > work properly > > because they don't like getting the LUN bits in the second > byte of the > > command string. We set those bits only because usb-storage > adjusts the > > SCSI revision level for all devices to SCSI-2; the drives > themselves > > report a value of 0x06 (which would be SCSI-7). > > > > The reason for mangling the scsi_level value was that some > USB devices > > reported SCSI-3 but couldn't handle some of the mandatory > features: VPD > > pages and the REPORT LUNS command. It's now clear that instead of > > abusing scsi_level, we should have separate flags for the > individual > > features we need to control. > > > > That's what this patch series does. The first merely corrects an > > existing typo in the definition of struct scsi_target. The > second adds > > the new flags and makes usb-storage use them. The third takes this > > opportunity to do a little code clean-up in usb-storage. > > > > The changes are more or less equally divided between SCSI and > > usb-storage. James, if they look okay to you and you don't > mind taking > > them through your tree, that would be fine. Or if you > prefer, I'm sure > > Greg won't mind taking them. > > I'll be glad to take these, James, any objection? > > thanks, > > greg k-h I handled this a bit differently, for our old 2.6.32 kernel, based on discussions on this list with Matthew Dharm back in April 2011. I changed the scsi_level entry in /sys to be read/write, rather than read-only. This allows a ussr-space white-list handler to fixup drives that are known to work. The gist of the discussion was whether the kernel should keep a white or black list for every drive on the planet to handle the scsi_level change/no-change or that user space could have the database and either apply it manually or automatically through udevd. Matthew expressed a preference for user space to manage the information. I can't find the patch set for these flag changes in my local email archive, but can we have controls for these available in user-space? Thanks, Dan > > -- > You received this message because you are subscribed to the > Google Groups "USB Mass Storage on Linux" group. > To post to this group, send email to > usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx. > To unsubscribe from this group, send email to > usb-storage+unsubscribe@xxxxxxxxxxxxxxxxxxxxxxxx. > For more options, visit this group at > http://groups.google.com/a/lists.one-eyed-alien.net/group/usb- > storage/?hl=en. > > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
