> pm8001_phy_control PHY_FUNC_HARD_RESET locks up on second try via > smp_phy_control because response HW_EVENT_PHY_START_STATUS fails to complete > previous command. The PM8001F_RUN_TIME flag is not treated as a bit, but a state > in all readers, yet once we are operational or in the run time state, the flags > use a bit-set operation. > [Jack Wang] Thanks for fix. Ack-by: Jack Wang <jack_wang@xxxxxxxxx> > Signed-off-by: mark_salyzyn@xxxxxxxxxxx > Cc: jack_wang@xxxxxxxxx > Cc: JBottomley@xxxxxxxxxxxxx > Cc: crystal_yu@xxxxxxxxx > Cc: john_gong@xxxxxxxxx > Cc: lindar_liu <lindar_liu@xxxxxxxxx> > > drivers/scsi/pm8001/pm8001_sas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/pm8001/pm8001_sas.c > b/drivers/scsi/pm8001/pm8001_sas.c > index fb3dc99..7ae22a6 100644 > --- a/drivers/scsi/pm8001/pm8001_sas.c > +++ b/drivers/scsi/pm8001/pm8001_sas.c > @@ -615,7 +615,7 @@ static int pm8001_dev_found_notify(struct domain_device > *dev) > wait_for_completion(&completion); > if (dev->dev_type == SAS_END_DEV) > msleep(50); > - pm8001_ha->flags |= PM8001F_RUN_TIME ; > + pm8001_ha->flags = PM8001F_RUN_TIME; > return 0; > found_out: > spin_unlock_irqrestore(&pm8001_ha->lock, flags); > > Sincerely -- Mark Salyzyn-- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
