re: [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Krishna Gudipati,

This is a semi-automatic email about new static checker warnings.

The patch 5b7db7af522d: "[SCSI] bfa: Implement LUN Masking feature 
using the SCSI Slave Callouts." from Dec 20, 2011, leads to the 
following Smatch complaint:

drivers/scsi/bfa/bfad_im.c +962 bfad_im_slave_alloc()
	 warn: variable dereferenced before check 'rport' (see line 959)

drivers/scsi/bfa/bfad_im.c
   957          struct fc_rport *rport = starget_to_rport(scsi_target(sdev));
   958		struct bfad_itnim_data_s *itnim_data =
   959					(struct bfad_itnim_data_s *) rport->dd_data;
                                                                     ^^^^^^^
New dereference.

   960		struct bfa_s *bfa = itnim_data->itnim->bfa_itnim->bfa;
   961	
   962		if (!rport || fc_remote_port_chkready(rport))
                     ^^^^^
Old check.

   963			return -ENXIO;
   964	

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux