On Tue, 10 Jan 2012 19:08:44 -0500 James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 2012-01-10 at 15:42 -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> > > Subject: drivers/scsi/sg.c: convert to kstrtoul_from_user() > > > > Instead of open coding this function use kstrtoul_from_user() directly. > > I really don't like these invent post facto functions and then try to > insert them on the grounds the original users are now "open coded". > However, if doug acks (or sends it as part of an update), I'll apply. > The main reason for adding helpers such as kstrtoul_from_user() is that we have recognised that certain code patterns appear in multiple places. So we add the helper and then clean up the code sites which inspired that addition. This is good! It's a part of our basic code maintenance. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
