On Mon, Dec 19, 2011 at 3:36 AM, David Dillow <dillowda@xxxxxxxx> wrote: > On Thu, 2011-12-01 at 20:10 +0100, Bart Van Assche wrote: > > /* > > * Copyright (c) 2005 Cisco Systems. All rights reserved. > > + * Copyright (c) 2010-2011 Bart Van Assche <bvanassche@xxxxxxx>. > > You've tried to add this in the past; I don't mean to deny you credit, > and I certainly value your work, but I'm not sure where the threshold is > for adding a copyright line. The excerpts below might provide some guidance (source: "The Copyright Handbook: What Every Writer Needs to Know"): [ ... ] There are strict technical requirements as to what a copyright notice must contain. Follow these rules exactly or your notice may be found to be invalid and not accomplish its intended purpose. A valid copyright notice contains three elements: * the copyright symbol * the year in which the work was published * the name of the copyright owner. It is not required that these elements appear in any particular order in the notice, but most notices are written in the order set forth above. We'll discuss each element in turn. [ ... ] If there are multiple authors, they should all be listed in the copyright notice. The authors' names can appear in any order. [ ... ] If I interpret the above correctly, at least two names are missing in the copyright header of the source file ib_srp.c. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html