On Thu, 2011-12-01 at 20:08 +0100, Bart Van Assche wrote: > Eliminate the private_rport_attrs[] array and the SETUP_*() macros > used to set up that array since the information in that array > duplicates the information in the static device attributes. Also, > trigger a kernel warning if SRP_RPORT_ATTRS is not large enough > since it is easy to forget to update that macro when adding new > attributes. Not sure I care one way or the other, but it looks to have been written the way it was to share a common code structure with the FC, SAS, and other SCSI transport code. They use a BUG_ON instead of WARN_ON, which seems more appropriate, since we just overran a buffer... The SCSI guys need to review this one, as it needs their ack. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
