On Thu, 2011-12-01 at 20:10 +0100, Bart Van Assche wrote: > Add the necessary functions in the SRP transport module to allow > an SRP initiator driver to implement transport layer recovery. I've run out of time today to look further, but I did want to point out that I think you're doing way too much in this patch. I like that you're moving some pieces into the transport, as it would be good to handle in-fabric/out-of-fabric there as well, as done for the FC transport. Getting there needs to be done through a series of patches rather one big patches, especially since you're touching code that multiple drivers use and need to get the core changes reviewed by so many people. I would need some quite some persuasion to be comfortable making large changes to srp_transport through the IB tree without ack's by Fujita and Brian. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
