On Fri, 2011-11-18 at 09:02 -0800, Chad Dupuis wrote:
> From: Saurav Kashyap <saurav.kashyap@xxxxxxxxxx>
>
> Add more fine grain parsing of vha->loop_state to export a more accurate
> fc_host port_state.
>
> Signed-off-by: Saurav Kashyap <saurav.kashyap@xxxxxxxxxx>
> Signed-off-by: Chad Dupuis <chad.dupuis@xxxxxxxxxx>
Could you pass your patches through checkpatch.pl, please? There are 17
errors in here including spaces instead of tabs and a missing space
before the opening bracket of an if clause.
I fixed it up this time.
James
> drivers/scsi/qla2xxx/qla_attr.c | 27 +++++++++++++++++++++++----
> 1 files changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index ac326c4..7acd442 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -1762,12 +1762,31 @@ qla2x00_get_host_port_state(struct Scsi_Host *shost)
> scsi_qla_host_t *vha = shost_priv(shost);
> struct scsi_qla_host *base_vha = pci_get_drvdata(vha->hw->pdev);
>
> - if (!base_vha->flags.online)
> + if (!base_vha->flags.online) {
> fc_host_port_state(shost) = FC_PORTSTATE_OFFLINE;
> - else if (atomic_read(&base_vha->loop_state) == LOOP_TIMEOUT)
> - fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN;
> - else
> + return;
> + }
> +
> + switch (atomic_read(&base_vha->loop_state)) {
> + case LOOP_UPDATE:
> + fc_host_port_state(shost) = FC_PORTSTATE_DIAGNOSTICS;
> + break;
> + case LOOP_DOWN:
> + if(test_bit(LOOP_RESYNC_NEEDED, &base_vha->dpc_flags))
> + fc_host_port_state(shost) = FC_PORTSTATE_DIAGNOSTICS;
> + else
> + fc_host_port_state(shost) = FC_PORTSTATE_LINKDOWN;
> + break;
> + case LOOP_DEAD:
> + fc_host_port_state(shost) = FC_PORTSTATE_LINKDOWN;
> + break;
> + case LOOP_READY:
> fc_host_port_state(shost) = FC_PORTSTATE_ONLINE;
> + break;
> + default:
> + fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN;
> + break;
> + }
> }
>
> static int
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
