On Sun, 2011-11-06 at 12:46 +0100, Bart Van Assche wrote: > On Sun, Nov 6, 2011 at 12:15 PM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > This patch converts the srp_max_req_size module parameter to R/W access > > so that it's accessable when built as CONFIG_INFINIBAND_SRPT=y. This > > accessible ? > > > includes adding srpt_device->max_req_size that is assigned during > > srpt_add_one() and referenced directly from there. > > I'm not sure it makes sense to store a copy of this parameter in the > srpt_device structure. If the HCA driver code (e.g. mlx4) is also > built into the kernel instead of as a separate module, any changes of > srp_max_req_size after ib_srpt and HCA driver initialization finished > won't have any effect. > So it sounds like srp_max_req_size with CONFIG_INFINIBAND_SRPT=y is not really going to be of much use anyways. What about just leaving it as read-only..? --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
