Re: srp_transport: Fix atttribute registration race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-10-21 at 18:57 +0200, Bart Van Assche wrote: 
> Register transport attributes after the attribute array has been
> set up instead of before. The current code is racy because there
> is no guarantee that the CPU examining the attribute container
> will see all values written to the container.

I don't agree with this change log.  As far as the kernel is concerned,
nothing happens until that function returns because the only way to use
anything is to get a match to succeed, and they all check for
->transportt which will be NULL.

I can accept that it's best practise to initialise something before
registering it, because the reverse excites everyone's bogosity sensors,
it's just not a bug in this case.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux