Smatch complains about a183a15f "[SCSI] lpfc 8.3.27: Changed worst case mailbox timeout". drivers/scsi/lpfc/lpfc_sli.c +2220 lpfc_sli_handle_mb_event(66) error: we previously assumed 'pmb->vport' could be null (see line 2177) + pmb->vport ? pmb->vport->vpi : 0, ^^^^^^^^^^ Checked. + pmbox->mbxCommand, + lpfc_sli_config_mbox_subsys_get(phba, + pmb), + lpfc_sli_config_mbox_opcode_get(phba, + pmb), + pmbox->mbxStatus, + pmbox->un.varWords[0], + pmb->vport->port_state); ^^^^^^^^^^^^ Dereferenced without checking. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html