On Mon, 2011-10-24 at 22:16 +0200, Bart Van Assche wrote: > On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: > >> Also, isn't kstrto*() preferred over strict_strto*() ? > > > > Not AFAIK. > > This is what I found in the description of commit 33ee3b2: > > kstrto*: converting strings to integers done (hopefully) right > > 1. simple_strto*() do not contain overflow checks and crufty, > libc way to indicate failure. > 2. strict_strto*() also do not have overflow checks but the name and > comments pretend they do. > 3. Both families have only "long long" and "long" variants, > but users want strtou8() > 4. Both "simple" and "strict" prefixes are wrong: > Simple doesn't exactly say what's so simple, strict should not exist > because conversion should be strict by default. > > The solution is to use "k" prefix and add convertors for more types. > Enter > kstrtoull() > ... Fair enough. I'll convert this separately after the merge considering it's a very minor improvement, and not a bugfix. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
