On Fri, 2011-10-14 at 12:47 +0300, Andy Shevchenko wrote: > On Fri, Oct 14, 2011 at 3:41 AM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > This patch converts ft_parse_wwn() to use hex_to_bin() instead of custom > > conversion code. > > > @@ -94,13 +95,10 @@ static ssize_t ft_parse_wwn(const char *name, u64 *wwn, int strict) > > return cp - name; > > } > > err = 3; > > - if (isdigit(c)) > > - nibble = c - '0'; > > - else if (isxdigit(c) && (islower(c) || !strict)) > > - nibble = tolower(c) - 'a' + 10; > > - else > > + val = hex_to_bin(c); > > + if (val < 0) > Just realized the patch has removed a bit of original logic. Above > line should be like > if (val < 0 || (strict && isupper(c))) > Same here, fixed in lio-core-2.6.git and rebased into the original patch in target-pending.git. Thanks! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
