On Sat, Oct 08, 2011 at 07:03:32PM -0700, Nicholas A. Bellinger wrote: > The reordering in transport_cmd_finish_abort() was not the issue here, > but the calling transport_remove_cmd_from_queue() when 'remove == 0'. > > This should not be a problem in transport_cmd_finish_abort_tmr() as we > always expect to release the tmr associated command. I know, but I'd really not have subtily different calling conventions between the two. Right now transport_cmd_finish_abort and transport_cmd_finish_abort_tmr only differ in: - transport_cmd_finish_abort calling transport_lun_remove_cmd - transport_cmd_finish_abort having the remove flag to make the transport_put_cmd (and with your patch the transport_remove_cmd_from_queue) call optional. I'd much rather add a conditional on the command beeing a TMR and merge the two into a single helper than having them diverge further. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
