On Fri, Sep 30, 2011 at 04:55:09AM +0000, Nicholas A. Bellinger wrote: > This patch also includes a bugfix related to TRANSPORT_FREE_CMD_INTR > operation, where core_tmr_drain_cmd_list will skip this cause in order > to prevent an ABORT_TASK status from being returned for descriptors that > are already queued up to be related by processing thread context. Please try to avoid mixing random bux fixes into code reorganization. I also really hate adding more special cases for TRANSPORT_FREE_CMD_INTR. Freeing a command from interrupt should really done by using a qla2xxx specific workqueue, and the core should not know about the pending free before we call into transport_generic_free_cmd. This is pretty important for the conversion of the target execution model to concurrent workqueues in addition to simply not making the code a mess. I guess I'll have move making qla2xxx not abusing the processing thread for everything the highest priority in that area so that we don't get more special cases for it added. Except for that is looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
