On Wed, Oct 05, 2011 at 09:35:13AM +0200, Rolf Eike Beer wrote: > > dev->supplement_adapter_info.MfgPcbaSerialNo); > > + > > + > > One newline too much. > True. I wish checkpatch.pl checked for that... > > + if (len > 16) > > + len = 16; > > max()? min() actually. I don't know that it improves the readability, but can do. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
