RE: [RFT PATCH] libsas: fix port->dev_list locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Wed, 2011-09-21 at 22:05 -0700, Dan Williams wrote:
> > port->dev_list maintains a list of devices attached to a given sas root
port.
> > It needs to be mutated under a lock as contexts outside of the
> > single-threaded-libsas-workqueue access the list via
> sas_find_dev_by_rphy().
> > Fixup locations where the list was being mutated without a lock.
> >
> > This is a follow-up to commit 5911e963 "[SCSI] libsas: remove expander
> > from dev list on error", where Luben noted [1]:
> >
> >     > 2/ We have unlocked list manipulations in
sas_ex_discover_end_dev(),
> >     > sas_unregister_common_dev(), and sas_ex_discover_end_dev()
> >
> >     Yes, I can see that and that is very unfortunate.
> >
> > [1]: http://marc.info/?l=linux-scsi&m=131480962006471&w=2
> 
> Since this call for testing was issued 11 days ago, did anyone actually
> test this patch?
> 
> James
> 
[Jack Wang] Hi James,
I do preliminary test, and it works fine.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux