Re: [PATCH] libsas: fix warnings when checking sata/stp protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It's OK for me.

[PATCH] libsas: fix warnings when checking sata/stp protocol
> 
> Several sas drivers legitimately check the protocol against the union of
> SAS_PROTOCOL_SATA and SAS_PROTOCOL_STP.  Provide a SAS_PROTOCOL_STP_ALL
> to silence warnings like:
> 
> drivers/scsi/pm8001/pm8001_sas.c:438:3: warning: case value '5' not in
> enumerated type 'enum sas_protocol' [-Wswitch]
> drivers/scsi/mvsas/mv_sas.c:798:2: warning: case value '5' not in
enumerated
> type 'enum sas_protocol' [-Wswitch]
> drivers/scsi/mvsas/mv_sas.c:1783:2: warning: case value '5' not in
enumerated
> type 'enum sas_protocol' [-Wswitch]
> drivers/scsi/mvsas/mv_sas.c:1886:2: warning: case value '5' not in
enumerated
> type 'enum sas_protocol' [-Wswitch]
> drivers/scsi/isci/request.c:3565:2: warning: case value '5' not in
enumerated
> type 'enum sas_protocol' [-Wswitch]
> 
> Cc: Xiangliang Yu <yuxiangl@xxxxxxxxxxx>
> Cc: Jack Wang <jack_wang@xxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  include/scsi/sas.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/scsi/sas.h b/include/scsi/sas.h
> index 9038d40..3a00297 100644
> --- a/include/scsi/sas.h
> +++ b/include/scsi/sas.h
> @@ -108,6 +108,7 @@ enum sas_protocol {
>  	SAS_PROTOCOL_STP		= 0x04,
>  	SAS_PROTOCOL_SSP		= 0x08,
>  	SAS_PROTOCOL_ALL		= 0x0E,
> +	SAS_PROTOCOL_STP_ALL		=
SAS_PROTOCOL_STP|SAS_PROTOCOL_SATA,
>  };
> 
>  /* From the spec; local phys only */
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux