On 10/09/11 5:13 PM, "Randy Dunlap" <rdunlap@xxxxxxxxxxxx> wrote: >From: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > >When CONFIG_NET is disabled, SCSI_QLA_ISCSI selects SCSI_ISCSI_ATTRS, >which uses network interfaces, so the build fails with multiple errors: > >warning: (ISCSI_TCP && SCSI_CXGB3_ISCSI && SCSI_CXGB4_ISCSI && >SCSI_QLA_ISCSI && INFINIBAND_ISER) selects SCSI_ISCSI_ATTRS which has >unmet direct dependencies (SCSI && NET) > >ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] >undefined! >ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] >undefined! >ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] >undefined! >ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >ERROR: "sysfs_format_mac" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined! > >so make SCSI_QLA_ISCSI also depend on NET to prevent the build errors. > >Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> >Cc: Ravi Anand <ravi.anand@xxxxxxxxxx> >Cc: Vikas Chaudhary <vikas.chaudhary@xxxxxxxxxx> >Cc: iscsi-driver@xxxxxxxxxx >--- > drivers/scsi/qla4xxx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >--- lnx-31-rc5.orig/drivers/scsi/qla4xxx/Kconfig >+++ lnx-31-rc5/drivers/scsi/qla4xxx/Kconfig >@@ -1,6 +1,6 @@ > config SCSI_QLA_ISCSI > tristate "QLogic ISP4XXX and ISP82XX host adapter family support" >- depends on PCI && SCSI >+ depends on PCI && SCSI && NET > select SCSI_ISCSI_ATTRS > ---help--- > This driver supports the QLogic 40xx (ISP4XXX) and 8022 (ISP82XX) Acked-by: Vikas Chaudhary <vikas.chaudhary@xxxxxxxxxx> This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html