Re: [PATCH] BNX2I: Fixed the endian on TTT for NOP out transmission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/26/2011 01:16 PM, Eddie Wai wrote:
> The iscsi_nopout task's TTT is defined as __be32 while the DMA
> memory to the chip is CPU specific.  This creates a problem for
> unsolicited NOP-In responses where the TTT is not the RESERVED
> tag of 0xFFs.  This patch adds a call to be32_to_cpu for the TTT
> specified.
> 
> Signed-off-by: Eddie Wai <eddie.wai@xxxxxxxxxxxx>
> ---
>  drivers/scsi/bnx2i/bnx2i_hwi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
> index 9ae80cd..dba72a4 100644
> --- a/drivers/scsi/bnx2i/bnx2i_hwi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
> @@ -563,7 +563,7 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn *bnx2i_conn,
>  	nopout_wqe->itt = ((u16)task->itt |
>  			   (ISCSI_TASK_TYPE_MPATH <<
>  			    ISCSI_TMF_REQUEST_TYPE_SHIFT));
> -	nopout_wqe->ttt = nopout_hdr->ttt;
> +	nopout_wqe->ttt = be32_to_cpu(nopout_hdr->ttt);
>  	nopout_wqe->flags = 0;
>  	if (!unsol)
>  		nopout_wqe->flags = ISCSI_NOP_OUT_REQUEST_LOCAL_COMPLETION;


Looks ok.

Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux