Hi, On Mon, Aug 15, 2011 at 9:44 PM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: > On 08/14/2011 04:18 PM, Maxin B John wrote: >> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@xxxxxxxxx> wrote: >>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this >>> in Kconfig so that the requirements are met automatically. >>> >>> Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx> > > OK So actually current osd_initiator code does not use these libraries. > It should, and I have very old code that started on that (hence the comment), > but it was never submitted to Kernel. The OSD protocol calls for all kind of > security levels that use these, but the current code only supports NO_SEC. > > I will keep your patch for when security code goes in. Meanwhile I should > at least remove the stale comment. Sorry for the delay in reply. Yes, this makes perfect sense to me. Cheers, Maxin -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html