On 08/24/2011 10:55 PM, adam radford wrote: > On Wed, Aug 24, 2011 at 8:35 AM, Tomas Henzl <thenzl@xxxxxxxxxx> wrote: >> Remove the call to megasas_shutdown_controller in the megasas_shutdown. > NACK. The call to megasas_shutdown_controller() should not be removed. > > megasas_shutdown_controller() does 3 things: > > 1. Cancels pended AEN command in firmware. > 2. Cancels pended map update command in firmware. > 3. Fires a MR_DCMD_CTRL_SHUTDOWN to notify firmware there was a clean > shutdown. Without this, FW will think there was an 'unclean shutdown' > on the next restart, which will cause rebuilds and other background FW > activity to kick on every shutdown/reboot. OK, from what I have seen the problem happens as a response to MR_DCMD_CTRL_SHUTDOWN (it means we could let the 1+2 pass and remove only the third point), but nobody wants 'background FW activity...' etc so let s skip patch. We need to find a better method for this problem. In the meantime - I've sent two patches, what do you think about the second one? It solves(hides) the problem too. Tomas > > -Adam > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
