Re: [PATCH 2/3] be2iscsi: Adding a shutdown Routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 08/22/2011 12:08 PM, Jayamohan Kallickal wrote:
>> +static void beiscsi_remove(struct pci_dev *pcidev)
>> +{
>> +
>> +	struct beiscsi_hba *phba = NULL;
>> +
>> +	phba = pci_get_drvdata(pcidev);
>
>
>> +static void beiscsi_shutdown(struct pci_dev *pcidev)
>> +{
>> +
>> +	struct beiscsi_hba *phba = NULL;
>> +
>> +	phba = (struct beiscsi_hba *)pci_get_drvdata(pcidev);
>
>
> No need for casting.

And no need to initialize to NULL either. Best would be

struct beiscsi_hba *phba = pci_get_drvdata(pcidev);

in both cases.

Eike
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux