On Wed, 2011-08-03 at 09:39 -0400, Rob Evers wrote:
> Unit attention commands are getting ignored when a dvd is
> replaced, resulting in errors when accessing the new dvd.
>
> This problem occurred when a system is booted in rescue
> mode via dvd and the dvd is then replaced with another dvd.
> Subsequent commands to a filesystem on the dvd, such as
> 'fsck' and 'restore' report errors.
>
> Solution suggested by Mike Christie.
>
> Signed-off-by: Rob Evers <revers@xxxxxxxxxx>
> ---
> drivers/scsi/scsi_error.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index a4b9cdb..725cc11 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -294,6 +294,10 @@ static int scsi_check_sense(struct scsi_cmnd *scmd)
> */
> if (scmd->device->expecting_cc_ua) {
> scmd->device->expecting_cc_ua = 0;
> + if (sdev->removable) {
> + sdev->changed = 1;
> + return SUCCESS;
> + }
Are you sure about this? We only set expecting_cc_ua if the device was
reset in error handling ... and there we definitely *don't* want to
trigger a medium change.
Surely we want this at the end of the UA handling clause?
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
