On Aug 01 James Bottomley wrote:
> On Mon, 2011-08-01 at 19:38 +0200, Stefan Richter wrote:
> > The mainline doesn't generally carry stubs and macros that are only there
> > for backporting. Well, I guess SCSI drivers are different in that regard.
>
> This is hardly a stub for a backport. It's a printk printing the
> version.
It is a printk printing a version that is only of interest in conjuction
with backports. And even in that context a "major.minor.build"
naming scheme for a device driver is quite naive. For example, a backport
of a driver which directly or indirectly uses the workqueue infrastructure
back into a kernel from before concurrency managed workqueues will behave
quite differently, regardless what its local version numbers say.
> At least 25% of drivers seem to do this (not that I entirely
> approve ... it does tend to clutter the boot sequence a bit)
25% of SCSI drivers perhaps (surely more than that if we consider only
SCSI drivers). My random sample of 46 loaded modules on a desktop PC
contains 3 drivers whose modinfo | grep -E '^version' is nonempty
(pata_atiixp, sg, r8169).
However, what 25% or 85% of all drivers do is not quite relevant to a new
driver.
> The whole reason for MODULE_VERSION() is to mark this correctly.
If you (the author, the subsystem maintainer) prefer to have a driver
version, consider to omit the driver init()'s printk at least. It is
redundant with lsmod, modinfo, or /sys/module/*{,/version}.
--
Stefan Richter
-=====-==-== =--- ----=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
