Re: [PATCH RFC/RFT 05/10] libfc: convert to blk bsg lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2011-07-24 at 03:59 -0500, michaelc@xxxxxxxxxxx wrote:
> From: Mike Christie <michaelc@xxxxxxxxxxx>
> 
> This patch converts libfc to the blk bsg lib. The differences
> visible to the driver are:
> - fc_bsg_job is now named bsg_job.
> - no rport pointer. Can access it through the device pointer.
> - the request and reply pointers on the blk_bsg_job struct
>   are now void pointers, so you cannot do bsg_job->request->some_field.
> 
> Patch is only quickly tested with fcping and made over scsi-misc.
> 
> Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
> Cc: Robert Love <robert.w.love@xxxxxxxxx>

Lightly tested using fcping and fcnsq from the fcoe-utils package. The
change seems like a good idea to me.

Tested-by: Robert Love <robert.w.love@xxxxxxxxx>

I noticed that there's a "Selected by: SCSI_ISCSI_ATTRS [=n] && SCSI
[=y] && NET [=y]" in the kernel configuration (make menuconfig), but I
didn't notice the same for SCSI_FC_ATTRS. I think we want that, and
maybe some other drivers want to have it auto-selected too.

//Rob
��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux