On Fri, 2011-07-08 at 18:18 -0700, Andy Grover wrote:
> pr_debug and dynamic debug messages are cool, we don't need specialized
> debug infrastructure.
>
> Use pr_err etc. instead of printk(KERN_ERR...).
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
> drivers/target/loopback/Kconfig | 6 -
> drivers/target/loopback/tcm_loop.c | 94 +++++-----
> drivers/target/loopback/tcm_loop.h | 6 -
> drivers/target/tcm_fc/tcm_fc.h | 24 ---
> drivers/target/tcm_fc/tfc_cmd.c | 37 ++---
> drivers/target/tcm_fc/tfc_conf.c | 33 ++--
> drivers/target/tcm_fc/tfc_io.c | 22 ++--
> drivers/target/tcm_fc/tfc_sess.c | 18 +-
> drivers/target/tcm_qla2xxx/tcm_qla2xxx_base.h | 6 -
> drivers/target/tcm_qla2xxx/tcm_qla2xxx_configfs.c | 190 ++++++++++----------
> drivers/target/tcm_qla2xxx/tcm_qla2xxx_fabric.c | 20 +-
> drivers/target/tcm_vhost/tcm_vhost_configfs.c | 50 +++---
> drivers/target/tcm_vhost/tcm_vhost_fabric.c | 10 +-
> drivers/target/tcm_vhost/tcm_vhost_scsi.c | 8 +-
> 14 files changed, 239 insertions(+), 285 deletions(-)
>
Great stuff, however with the amount of I/O path code that was removed
in:
commit 0b5660d2eebadc5853cf268d6136aeecbd251d6a
Author: Andy Grover <agrover@xxxxxxxxxx>
Date: Fri Jul 8 17:25:13 2011 -0700
target: Make all control CDBs scatter-gather
and:
commit 84b6dd77a6035dff105f628589b8aac8a227031e
Author: Andy Grover <agrover@xxxxxxxxxx>
Date: Fri Jul 8 15:22:14 2011 -0700
target: Eliminate usage of struct se_mem
really made things difficult to debug the bigger issue with this
series..
So that said, some new pr_debug() messages for the I/O path would be
really helpful.. ;)
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
