On Thu, Jul 14, 2011 at 10:07:21AM -0700, giridhar.malavali@xxxxxxxxxx wrote: > The patch 1/3 has couple of warnings w.r.t KERN_facility level with printk. > > WARNING: printk() should include KERN_ facility level > > Using KERN facility in printk will print each buffer information in new line causing > unreadable log messages. > > Here is an example > > With KERN facility > Mar 23 10:05:37 linux-dcaw kernel: qla2xxx [0000:18:00.6]4:1102: > Mar 23 10:05:37 linux-dcaw kernel: 42 > Mar 23 10:05:37 linux-dcaw kernel: > Mar 23 10:05:37 linux-dcaw kernel: 00 > > Without KERN facility > Mar 21 13:07:35 linux-dcaw kernel: qla2xxx [0000:18:00.7]37:1102: 48 00 00 00 5b f2 00 I think you want to use KERN_CONT to avoid this warning. BUT, note the problem: /* * Annotation for a "continued" line of log printout (only done after a * line that had no enclosing \n). Only to be used by core/arch code * during early bootup (a continued line is not SMP-safe otherwise). */ #define KERN_CONT "<c>" If you're not OK with potentially interspersed messages, you need to accumulate into your own buffer and send it down with a single printk. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
