On Wed, Jun 15, 2011 at 05:16:28PM +0900, Nao Nishijima wrote: > Allow users to set the preferred name of device via sysfs interface. > > (Exsample) sda -> foo > # echo foo > /sys/block/sda/preferred_name > > Suggested-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Suggested-by: Jon Masters <jcm@xxxxxxxxxx> > Signed-off-by: Nao Nishijima <nao.nishijima.xt@xxxxxxxxxxx> You don't document this new sysfs file (which is required), nor do you explain what it is for and how to use it. Please do that in this patch, and in a Documentation/ABI/ file for any new sysfs file you create. I still fail to understand how a "preferred" file will help anyone out here at all... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html