Re: [PATCH 04/12] bfa: Brocade-1860 Fabric Adapter Hardware Enablement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



kgudipat@xxxxxxxxxxx wrote:
> From: Krishna Gudipati <kgudipat@xxxxxxxxxxx>
> 
> Change details:
> 	- Added support for Brocade-1860 Fabric Adapter.
> 	- Made changes to support single firmware image per asic type.
> 	- Combined bfi_cbreg.h and bfi_ctreg.h defines into bfi_reg.h with
> 	  only minimal defines used by host.
> 	- Added changes to setup CPE/RME Queue register offsets based on
> 	  firmware response.
> 	- Removed queue register offset initializations and added register offsets
> 	  to BFI config response message.
> 	- Added Brocade-1860 asic specific interrupt status definitions and
> 	  mailbox interfaces.
> 
> Signed-off-by: Krishna Gudipati <kgudipat@xxxxxxxxxxx>
> ---
>  drivers/scsi/bfa/bfa.h        |   14 +-
>  drivers/scsi/bfa/bfa_core.c   |  209 +++++++++-----
>  drivers/scsi/bfa/bfa_defs.h   |   13 +-
>  drivers/scsi/bfa/bfa_hw_cb.c  |   34 +--
>  drivers/scsi/bfa/bfa_hw_ct.c  |   75 ++----
>  drivers/scsi/bfa/bfa_ioc.c    |  144 ++++++---
>  drivers/scsi/bfa/bfa_ioc.h    |  117 +++++---
>  drivers/scsi/bfa/bfa_ioc_cb.c |   56 ++--
>  drivers/scsi/bfa/bfa_ioc_ct.c |  418 ++++++++++++++++++++++------
>  drivers/scsi/bfa/bfa_port.c   |    2 -
>  drivers/scsi/bfa/bfad.c       |   81 +++---
>  drivers/scsi/bfa/bfad_drv.h   |    1 +
>  drivers/scsi/bfa/bfad_im.c    |    2 +-
>  drivers/scsi/bfa/bfi.h        |   62 +++--
>  drivers/scsi/bfa/bfi_cbreg.h  |  305 --------------------
>  drivers/scsi/bfa/bfi_ctreg.h  |  636
> ----------------------------------------- drivers/scsi/bfa/bfi_ms.h     |  
> 36 +++
>  drivers/scsi/bfa/bfi_reg.h    |  428 +++++++++++++++++++++++++++
>  18 files changed, 1262 insertions(+), 1371 deletions(-)
>  delete mode 100644 drivers/scsi/bfa/bfi_cbreg.h
>  delete mode 100644 drivers/scsi/bfa/bfi_ctreg.h
>  create mode 100644 drivers/scsi/bfa/bfi_reg.h

[12k lines diff]

This patch is _way_ to big. And it's impossible to review. I suggest e.g. 
splitting the header merge things out of them so that these become a simple 
code move without any other changes. And some of the other patches likely 
deserve their own patch.

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux