Removed the redundant check for (!i) and reworked the patch.
Thanks
Jay
________________________________________
From: Rolf Eike Beer [eike-kernel@xxxxxxxxx]
Sent: Wednesday, June 01, 2011 12:41 PM
To: Kallickal, Jayamohan
Cc: prarit@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; mchristi@xxxxxxxxxx
Subject: RE: [PATCH]: be2iscsi: Fix MSIX interrupt names
> I have taken the original patch from Prarit and made changes to move the
> allocation
> inside the main for loop along with request_irq.
>
> I feel doing devres would be good but going to take some time. However, we
> need to fix this now and hence
> am submitting this patch. When we have a final devres solution working and
> tested ,we would move over.
I think this is a good way to go.
+ if (!phba->msi_name[i]) {
+ ret = -ENOMEM;
+ if (!i)
+ return ret;
+ goto free_msix_irqs;
+ }
That "if (!i)" stuff is useless. If you enter the loop with i==0 j will
become -1 which causes the loop never to execute. The same is true for the
request_irq() error handling below.
Eike
Attachment:
0001-be2iscsi-Fixing-the-proc-interrupts-problem-V2.patch
Description: 0001-be2iscsi-Fixing-the-proc-interrupts-problem-V2.patch
