On Tue, 2011-05-31 at 12:22 +0200, Christoph Hellwig wrote: > > +++ b/drivers/target/iscsi/iscsi_target.c > > @@ -1118,7 +1118,7 @@ attach_cmd: > > * the underlying transport plugin has allocated the buffer to > > * receive the Immediate Write Data into. > > */ > > - transport_generic_handle_cdb(SE_CMD(cmd)); > > + transport_generic_new_cmd(SE_CMD(cmd)); > > This is still missing the error handling, as well as the other callers > in the iscsi code. When adding the proper error handling please do it > by checking the transport_generic_new_cmd return value instead of > through transport_new_cmd_failure. With a bit more work this should > also allow killing off the SCF_SE_CMD_FAILED flag. > <nod>. I will have a look getting this addressed later today as well and send out a follow-up patch on top of what has been pushed so far of Andy's patches into lio-core-2.6.git. Thanks, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
