- please remove all the extra -I lines in EXTRA_CLFAGs, none of them
should be needed.
- CONFIGFS_TCM_FC_DEBUG should be used directly in the code instead of
definining another symbol
- there's no need for thread_wq, you can just do a wake_up_process
on the task_struct for the thread. That also means you don't have
the races with the kthread API you currently have
- The set_user_nice in ft_thread needs a comment explaning why you
really need to mess with priorities here. I suspect you don't have
to anyway.
- There's lots of code like "if (!(acl)) {" with completley superflous
braces.
In general it would have been nice to have sent a review request to
linux-scsi, especially as most of these items have been commented on
multiple times for other target frontends before.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
