On 2011-05-24 19:18, James Bottomley wrote: > Bugzilla report is here: > > https://bugzilla.kernel.org/show_bug.cgi?id=35682 > > The problem occurs if blk_run_queue() or its variants is called after > blk_cleanup_queue() is called. The run checks should have a state guard > for QUEUE_FLAG_DEAD. Since a DEAD queue is always STOPPED, just fold it > into the blk_queue_stopped() test. > > Signed-off-by: James Bottomley <jbottomley@xxxxxxxxxxxxx> > > --- > > Jens, can you look at this, please ... would you prefer a separate DEAD > test instead? Incidentally, this is in addition to the other DEAD test > you still haven't applied ... Seems a bit of a mixup. Would be cleaner to set STOPPED when it is marked dead, but I suspect that will kill erroring out IO when the device goes away unless we add some logic to ensure that happens without the drivers help. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html