On Thu, 2011-05-19 at 14:41 -0400, David Jeffery wrote:
> This is a resend of a patch with some minor whitespace cleanups which I'd
> like to have considered for inclusion.
Not enough, though:
WARNING: line over 80 characters
#53: FILE: drivers/scsi/scsi_error.c:964:
+static int scsi_eh_test_devices(struct list_head *cmd_list, struct
list_head *work_q, struct list_head *done_q, int try_stu)
ERROR: trailing whitespace
#63: FILE: drivers/scsi/scsi_error.c:974:
+^I^Ifinish_cmds = !scsi_device_online(scmd->device) || $
WARNING: line over 80 characters
#64: FILE: drivers/scsi/scsi_error.c:975:
+ (try_stu && !scsi_eh_try_stu(scmd) && !
scsi_eh_tur(scmd)) ||
ERROR: trailing whitespace
#66: FILE: drivers/scsi/scsi_error.c:977:
+^I^I^I$
ERROR: space required before the open parenthesis '('
#196: FILE: drivers/scsi/scsi_error.c:1303:
+ } else if(rtn == FAST_IO_FAIL) {
total: 3 errors, 2 warnings, 172 lines checked
checkpatch.pl is your friend ...
This is pretty trivial, so I fixed it up manually (I usually only care
about errors, but in this case the warning about the function template
and long line needed fixing to match the file).
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
