On Wed, Apr 27, 2011 at 9:07 AM, Roland Dreier <roland@xxxxxxxxxx> wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
>
> The code really intends to make sure that neither inquiry_prod nor
> inquiry_rev is NULL.
>
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
> drivers/target/target_core_transport.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 9583b23..4a03098 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1725,7 +1725,7 @@ struct se_device *transport_add_device_to_core_hba(
> * setup.
> */
> if (TRANSPORT(dev)->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) {
> - if (!(inquiry_prod) || !(inquiry_prod)) {
> + if (!inquiry_prod || !inquiry_rev) {
> printk(KERN_ERR "All non TCM/pSCSI plugins require"
> " INQUIRY consts\n");
> goto out;
>
Hi Nick, did you ever get a chance to look at this? Seems pretty obvious to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
