* James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 2011-04-14 at 20:15 +0200, Ingo Molnar wrote: > > * James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > + /* temporary expedient, try to catch use of queue lock after > > > + * free of sdev */ > > > + sdev->request_queue = NULL; > > > > Couldnt help to notice this small ugliness while skimming the patch - please > > use the customary (multi-line) comment style: > > > > /* > > * Comment ..... > > * ...... goes here. > > */ > > It's just code motion, so it was cut and paste. The actual file is a nasty > mix of comment styles, so it doesn't really matter one way or the other. That's not really true - most other multi-line comments are fine in that file - i checked that before sending my feedback. Really, why are you even arguing about it? You have not noticed it during review - that can happen - but you should really fix small details if someone points them out during review. Instead you are forcing reviewers though an unnecessary and time-wasting email exchange. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
