Re: [PATCH resend] atp870u: use pci_dev->revision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On Friday 11 February 2011 10:49:34 pm Sergei Shtylyov wrote:

> This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
> converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
> drivers to use pci_device->revision).

> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
 
> ---
> Resending with a proper tear line...

>  drivers/scsi/atp870u.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/drivers/scsi/atp870u.c
> ===================================================================
> --- linux-2.6.orig/drivers/scsi/atp870u.c
> +++ linux-2.6/drivers/scsi/atp870u.c
> @@ -2583,7 +2583,7 @@ static int atp870u_probe(struct pci_dev 
>  	 * this than via the PCI device table
>  	 */
>  	if (ent->device == PCI_DEVICE_ID_ARTOP_AEC7610) {
> -		error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
> +		atpdev->chip_ver = pdev->revision;
>  		if (atpdev->chip_ver < 2)
>  			goto err_eio;
>  	}
> @@ -2602,7 +2602,7 @@ static int atp870u_probe(struct pci_dev 
>  	base_io &= 0xfffffff8;
>  
>  	if ((ent->device == ATP880_DEVID1)||(ent->device == ATP880_DEVID2)) {
> -		error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
> +		atpdev->chip_ver = pdev->revision;
>  		pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x80);//JCC082803
>  
>  		host_id = inb(base_io + 0x39);

   Hm. Will this and 2 other analogous patches of mine be queued somewhere?

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux