Re: [RFC PATCH 4/6] isci: hardware / topology event handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 23, 2011 at 05:07:49PM -0700, Dan Williams wrote:
> One of the fixes I made in that interim timer api cleanup (8d32e5b2)
> was to use del_timer_sync on all pre-allocated timers to make sure
> nothing fired or was in the process of firing as the driver was
> brought down (unlikely).  The core runs under
> spin_lock_irqsave(ihost->scic_lock) context, and the expectation is
> that all these timeout callbacks are done in that context.

I'm afraid that you'll have to fix that design mistake first.  Running
large amounts of code under a spinlock just is not a good idea for
a wide range of reasons.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux