On Wed, Mar 23 2011 at 6:03pm -0400,
James Bottomley <James.Bottomley@xxxxxxx> wrote:
> On Wed, 2011-03-23 at 17:58 -0400, Mike Snitzer wrote:
> > On Mon, Mar 21 2011 at 7:16pm -0400,
> > Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
> >
> > > > It's a bug fix: of course it can.
> > >
> > > Right, so given scsi_dh_activate()'s {get,put}_device() that wraps the
> > > call to scsi_dh->activate (aka clariion_activate) I'm not seeing how
> > > accessing sdev->sdev_gendev (via sdev_printk) could result in a panic.
> > > So I'll need to dig deeper (hopefully with Eddie's assistance)...
> >
> > Hi James,
> >
> > I checked with Eddie and the sdev_printk() panic he saw no longer occurs
> > when commit db422318 is in place. But he also tested with the patch I
> > provided below.
> >
> > I still feel this fix is needed and would like to get your feedback on
> > this (relative to 2.6.39):
>
> So what about the fix you propose in
>
> Message-id: <20110321231657.GA12902@xxxxxxxxxx>
>
> ? That looks to be the correct one.
Yes, that is the correct fix (that is the same patch I quoted in my mail
preceeding this one).
We'd need it in 2.6.38.y too.
Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
