On Wed, 2011-03-23 at 17:54 +0900, FUJITA Tomonori wrote: > I've not looked at the code yet but... > > On Tue, 22 Mar 2011 20:06:31 -0700 > "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx> wrote: > > > Nicholas Bellinger (14): > > iscsi: Resolve iscsi_proto.h naming conflicts with > > drivers/target/iscsi > > iscsi: Add Serial Number Arithmetic LT and GT into iscsi_proto.h > > target: Convert REPORT_LUNs to use int_to_scsilun > > iscsi-target: Add iSCSI fabric support for target v4 > > iscsi-target: Add TCM v4 compatiable ConfigFS control plane > > iscsi-target: Add configfs fabric dependent statistics > > iscsi-target: Add TPG and Device logic > > iscsi-target: Add iSCSI Login Negotiation and Parameter logic > > iscsi-target: Add CHAP Authentication support using libcrypto > > iscsi-target: Add Sequence/PDU list + DataIN response logic > > iscsi-target: Add iSCSI Error Recovery Hierarchy support > > iscsi-target: Add support for task management operations > > iscsi-target: Add misc utility and debug logic > > iscsi-target: Add Makefile/Kconfig and update TCM top level > > > > drivers/infiniband/ulp/iser/iser_initiator.c | 2 +- > > drivers/scsi/be2iscsi/be_main.h | 4 +- > > drivers/scsi/bnx2i/bnx2i_hwi.c | 8 +- > > drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 +- > > drivers/scsi/libiscsi.c | 22 +- > > drivers/target/Kconfig | 2 + > > drivers/target/Makefile | 3 + > > drivers/target/iscsi/Kconfig | 17 + > > drivers/target/iscsi/Makefile | 20 + > > drivers/target/iscsi/iscsi_target.c | 5017 +++++++++++++++++++++ > > drivers/target/iscsi/iscsi_target.h | 32 + > > drivers/target/iscsi/iscsi_target_auth.c | 496 ++ > > drivers/target/iscsi/iscsi_target_auth.h | 32 + > > drivers/target/iscsi/iscsi_target_configfs.c | 1914 ++++++++ > > drivers/target/iscsi/iscsi_target_configfs.h | 7 + > > drivers/target/iscsi/iscsi_target_core.h | 881 ++++ > > drivers/target/iscsi/iscsi_target_datain_values.c | 531 +++ > > drivers/target/iscsi/iscsi_target_datain_values.h | 15 + > > drivers/target/iscsi/iscsi_target_debug.h | 113 + > > drivers/target/iscsi/iscsi_target_device.c | 108 + > > drivers/target/iscsi/iscsi_target_device.h | 9 + > > drivers/target/iscsi/iscsi_target_erl0.c | 1005 +++++ > > drivers/target/iscsi/iscsi_target_erl0.h | 17 + > > drivers/target/iscsi/iscsi_target_erl1.c | 1305 ++++++ > > drivers/target/iscsi/iscsi_target_erl1.h | 28 + > > drivers/target/iscsi/iscsi_target_erl2.c | 483 ++ > > drivers/target/iscsi/iscsi_target_erl2.h | 18 + > > drivers/target/iscsi/iscsi_target_login.c | 1245 +++++ > > drivers/target/iscsi/iscsi_target_login.h | 13 + > > drivers/target/iscsi/iscsi_target_nego.c | 1068 +++++ > > drivers/target/iscsi/iscsi_target_nego.h | 19 + > > Why do we need to do the pre-nexus operations such as login, > authentication, negotiation, etc in kernel? > Because defining an API for this type of userspace code is an unnecessary overhead that iscsi_target_mod does not require. I really don't want to add any type of C level interface/API and C userspace code for fabric level login logic that is intended to be transparent to the actual iscsi-target configfs control plane. It's just unnecessary complexity and C userspace code for a kernel-level implementation with no obvious benefit. The area where some form of userspace passthrough specific to iSCSI login negotiation in CURRENT_STAGE=0 would be useful is for userspace authentication support beyond the built-in kernel-level CHAP code for extending AuthMethod to support Kerberos, SRP, etc. This should be limited to the AuthMethod state and keys, and the rest of fabric login should still reside in-kernel. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
