On 03/21/2011 04:05 PM, James Bottomley wrote: > On Mon, 2011-03-21 at 16:01 -0500, Brian King wrote: >> On 03/20/2011 08:09 PM, FUJITA Tomonori wrote: >>> Thanks for the testings, >>> >>> On Fri, 18 Mar 2011 15:58:53 -0500 >>> Brian King <brking@xxxxxxxxxxxxxxxxxx> wrote: >>> >>>> On 03/07/2011 08:40 AM, James Bottomley wrote: >>>>> On Mon, 2011-03-07 at 13:41 +0900, FUJITA Tomonori wrote: >>>>>> On Sat, 12 Feb 2011 14:27:26 -0600 >>>>>> James Bottomley <James.Bottomley@xxxxxxx> wrote: >>>>>> >>>>>>>> Disregard my previous comment. It looks like current client should handle reservations >>>>>>>> just fine without any further changes. >>>>>>> >>>>>>> So is that an ack for putting this in scsi-misc ... or did you want to >>>>>>> do more testing first? >>>>>> >>>>>> Ping, >>>>>> >>>>>> Brian, James, can we merge this during the next merge window? >>>>> >>>>> I'm still waiting for an ack from Brian. >>>> >>>> Sorry for the delay... I've got this loaded in the lab and have managed to oops >>>> a couple times. The first one was during shutdown, which I wasn't able to collect >>>> any data for. The most recent occurred when a client was trying to login for the >>>> first time: >>> >>> You mean that the kernel crashes every time when a client logs in? >> >> I think the crash I was seeing when the client logs in was just due to the fact that >> I had things misconfigured. It took me a bit to figure out the configfs stuff. Didn't >> realize at first I had to go off and manually create a lot of the configfs layout >> described in the wiki page. Once I did that, I was able to get a LUN to successfully >> report in on the client side. I'll start pounding on this a bit and see how things >> hold up. > > Hmm, so that still indicates the error handling is screwed at this > point. That, I suppose, should be fixable (plus being a fix, it's merge > window exempt). Do you want this in now, or wait until next merge > window? Since this would replace ibmvstgt, and I've been running into issues fairly quickly, it might be prudent to wait until the next merge window. If it was a new driver or if there was some way to still build the old ibmvstgt driver, I'd feel more comfortable with pushing it in. Thanks, Brian -- Brian King Linux on Power Virtualization IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html